chore: follow-up corrections for commits merged 2026-06-04 → 2026-06-05#12557
Open
Planeshifter wants to merge 2 commits into
Open
chore: follow-up corrections for commits merged 2026-06-04 → 2026-06-05#12557Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
Aligns with sibling benchmarks in `gcuany`, `gcuevery`, and `gcunone`, which import the primitive predicate accessor rather than the broader default export.
Replaces the self-referential `@stdlib/fft/base/fftpack` import with imports of the `decompose` and `rffti` sub-packages so the namespace interface mirrors `lib/index.js`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request applies follow-up fixes for commits merged to
developbetween 2026-06-04 14:06:38 -0500 (39f37bf) and 2026-06-05 02:06:31 -0700 (6b0591c), surfaced by an automated review pass over the 33-commit, 158-file window.Themes covered by the review window: new
fft/fft/base/fft/base/fftpacknamespace scaffolding (Athan Reines), newblas/ext/base/gcuanyandgcusomepackages (Muhammad Haris), and a broad TypeScript declaration normalization sweep acrossblasandstats(Philipp Burckhardt). Fixes below address concrete inconsistencies introduced in two of those namespaces:e55fddc: userequire( '@stdlib/assert/is-boolean' ).isPrimitiveinstead of the baseisBooleanimport inblas/ext/base/gcusome/benchmark/benchmark.jsandbenchmark.ndarray.js, consistent withgcuany,gcuevery, andgcunonesibling benchmarks.lib/node_modules/@stdlib/fft/base/fftpack/docs/types/index.d.ts(3a0597c) by importingdecomposefrom its own package path and adding the missingrfftimember so theNamespaceinterface mirrorslib/index.js.Related Issues
No.
Questions
No.
Other
Validation performed:
fftnamespace scaffolding and the newblas/ext/base/gcuanyandgcusomepackages, comparing each against established sibling packages (gcuevery,gcunone,blas/ext/base/docs/types/index.d.ts).Layoutenum adoption, TSDoc text normalization, generic constraint cleanup,gaxpyalpha-type decoupling,LastIndexOfPascalCase rename).Deliberately excluded from this PR:
ftt/basetypo in commit7fd86dd's subject line (typo ondevelop; not editable from a follow-up branch).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as a scheduled follow-up review pass over the last 24 hours of commits merged to
develop. Four parallel reviewer agents (two style-guide audits, two diff-only bug scans) surfaced candidate issues; only issues independently re-verifiable from the diff and the corresponding sibling files in-tree were applied here. A maintainer should audit before promoting from draft.@stdlib-js/reviewers
Generated by Claude Code