Skip to content

chore: follow-up corrections for commits merged 2026-06-04 → 2026-06-05#12557

Open
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-06-05
Open

chore: follow-up corrections for commits merged 2026-06-04 → 2026-06-05#12557
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-06-05

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request applies follow-up fixes for commits merged to develop between 2026-06-04 14:06:38 -0500 (39f37bf) and 2026-06-05 02:06:31 -0700 (6b0591c), surfaced by an automated review pass over the 33-commit, 158-file window.

Themes covered by the review window: new fft / fft/base / fft/base/fftpack namespace scaffolding (Athan Reines), new blas/ext/base/gcuany and gcusome packages (Muhammad Haris), and a broad TypeScript declaration normalization sweep across blas and stats (Philipp Burckhardt). Fixes below address concrete inconsistencies introduced in two of those namespaces:

  • Fix e55fddc: use require( '@stdlib/assert/is-boolean' ).isPrimitive instead of the base isBoolean import in blas/ext/base/gcusome/benchmark/benchmark.js and benchmark.ndarray.js, consistent with gcuany, gcuevery, and gcunone sibling benchmarks.
  • Fix circular self-import in lib/node_modules/@stdlib/fft/base/fftpack/docs/types/index.d.ts (3a0597c) by importing decompose from its own package path and adding the missing rffti member so the Namespace interface mirrors lib/index.js.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed:

  • Style-guide compliance pass against the new fft namespace scaffolding and the new blas/ext/base/gcuany and gcusome packages, comparing each against established sibling packages (gcuevery, gcunone, blas/ext/base/docs/types/index.d.ts).
  • Style-guide compliance pass over Philipp Burckhardt's TypeScript declaration sweep (stride/offset renames, Layout enum adoption, TSDoc text normalization, generic constraint cleanup, gaxpy alpha-type decoupling, LastIndexOf PascalCase rename).
  • Two independent diff-only bug scans (one focused on objective coding errors verifiable from the diff, one on introduced-code semantics and security).
  • stdlib-bot auto-regenerated artefacts (assert TS decls, REPL namespace docs, related-packages sections) were excluded — they are mechanical regenerations and not human-authored.

Deliberately excluded from this PR:

  • Subjective concerns, "could be better" suggestions, and anything requiring code outside the diff window to validate.
  • The ftt/base typo in commit 7fd86dd's subject line (typo on develop; not editable from a follow-up branch).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance.

This PR was authored by Claude Code as a scheduled follow-up review pass over the last 24 hours of commits merged to develop. Four parallel reviewer agents (two style-guide audits, two diff-only bug scans) surfaced candidate issues; only issues independently re-verifiable from the diff and the corresponding sibling files in-tree were applied here. A maintainer should audit before promoting from draft.


@stdlib-js/reviewers


Generated by Claude Code

claude added 2 commits June 5, 2026 12:29
Aligns with sibling benchmarks in `gcuany`, `gcuevery`, and `gcunone`,
which import the primitive predicate accessor rather than the broader
default export.
Replaces the self-referential `@stdlib/fft/base/fftpack` import with
imports of the `decompose` and `rffti` sub-packages so the namespace
interface mirrors `lib/index.js`.
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gcusome $\color{green}294/294$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}294/294$
$\color{green}+100.00\%$
fft/base/fftpack $\color{red}539/726$
$\color{green}+74.24\%$
$\color{green}6/6$
$\color{green}+100.00\%$
$\color{red}0/3$
$\color{green}+0.00\%$
$\color{red}539/726$
$\color{green}+74.24\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title fix: follow-up corrections for commits merged 2026-06-04 → 2026-06-05 chore: follow-up corrections for commits merged 2026-06-04 → 2026-06-05 Jun 5, 2026
@Planeshifter Planeshifter marked this pull request as ready for review June 5, 2026 15:15
@Planeshifter Planeshifter requested review from a team and kgryte June 5, 2026 15:15
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants