feat: add C implementation for `stats/base/dists/f/pdf` by nirmaljb · Pull Request #10136 · stdlib-js/stdlib

nirmaljb · 2026-02-07T10:42:12Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: na
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: missing_dependencies
task: lint_c_examples status: missing_dependencies
task: lint_c_benchmarks status: missing_dependencies
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: na
task: lint_license_headers status: passed ---

Resolves #3599

Description

What is the purpose of this pull request?

This pull request:

Adds a C implementation of the f pdf.
Includes benchmarks for the C implementation.
Provides examples demonstrating the usage of the f PDF in C.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

[RFC]: Add C implementation for @stdlib/stats/base/dists/f/pdf #3599

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2026-02-07T10:45:07Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/f/pdf	$\color{red}598/646$ $\color{green}+0.00%$	$\color{red}62/66$ $\color{green}+0.00%$	$\color{green}6/6$ $\color{green}+0.00%$	$\color{red}598/646$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter

Left some feedback.

Planeshifter · 2026-04-20T05:32:34Z

+	t.end();
+});
+
+tape( 'the function evaluates the pdf for `x` given large `d1` and `d2` (tested against the Boost C++ library', opts, function test( t ) {


Missing closing ) in the description string.

Suggested change

tape( 'the function evaluates the pdf for `x` given large `d1` and `d2` (tested against the Boost C++ library', opts, function test( t ) {

tape( 'the function evaluates the pdf for `x` given large `d1` and `d2` (tested against the Boost C++ library)', opts, function test( t ) {

Planeshifter · 2026-04-20T05:32:34Z

+* @returns   evaluated PDF
+*
+* @example
+* double y = pdf( 2.0, 0.5, 1.0 );


The @example must use the full C name stdlib_base_dists_f_pdf, not the short alias. See stats/base/dists/beta/pdf/src/main.c:36.

Suggested change

* double y = pdf( 2.0, 0.5, 1.0 );

* double y = stdlib_base_dists_f_pdf( 2.0, 0.5, 1.0 );

Planeshifter · 2026-04-20T05:32:34Z

+* @param     x - function parameter
+* @param     y - probability equal to `1-x`
+* @param     normalized - boolean indicating whether to evaluate the power terms of the regularized or non-regularized incomplete beta function
+* @returns   power terms


C sources use @param name description (no dash, aligned) and @return (no trailing s). Same issue at lines 231–234 and 250–253.

Planeshifter · 2026-04-20T05:32:34Z

+
+	b.tic();
+	for ( i = 0; i < b.iterations; i++ ) {
+		y = pdf( x[ i % len ], d1[ i % len ], d2[ i % len ]);


Missing space before the closing ).

Suggested change

y = pdf( x[ i % len ], d1[ i % len ], d2[ i % len ]);

y = pdf( x[ i % len ], d1[ i % len ], d2[ i % len ] );

Planeshifter · 2026-04-20T05:32:34Z

+	double d1;
+	double d2;
+	double y;
+	int32_t i;


Use int i for the loop counter and drop the #include <stdint.h> at line 22. Every other example under stats/base/dists follows this pattern.

Planeshifter · 2026-04-20T05:32:35Z

+    double d1;
+    double d2;
+    double y;
+    int32_t i;


Same as example.c: use int i for the loop counter and remove the <stdint.h> include at line 214.

Planeshifter · 2026-04-20T05:32:35Z

+
+

Drop the double blank line between the description and the code block; should be a single blank line.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 7, 2026

nirmaljb mentioned this pull request Feb 10, 2026

Office Hours (2026-02-10) stdlib-js/meetings#80

Closed

Planeshifter requested changes Apr 20, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add C implementation for `stats/base/dists/f/pdf`#10136

feat: add C implementation for `stats/base/dists/f/pdf`#10136
nirmaljb wants to merge 2 commits intostdlib-js:developfrom
nirmaljb:feat/f-pdf

nirmaljb commented Feb 7, 2026

Uh oh!

stdlib-bot commented Feb 7, 2026 •

edited

Loading

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Apr 20, 2026

Uh oh!

Planeshifter Apr 20, 2026

Uh oh!

Planeshifter Apr 20, 2026

Uh oh!

Planeshifter Apr 20, 2026

Uh oh!

Planeshifter Apr 20, 2026

Uh oh!

Planeshifter Apr 20, 2026

Uh oh!

Planeshifter Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	tape( 'the function evaluates the pdf for `x` given large `d1` and `d2` (tested against the Boost C++ library', opts, function test( t ) {
	tape( 'the function evaluates the pdf for `x` given large `d1` and `d2` (tested against the Boost C++ library)', opts, function test( t ) {

	* double y = pdf( 2.0, 0.5, 1.0 );
	* double y = stdlib_base_dists_f_pdf( 2.0, 0.5, 1.0 );

	y = pdf( x[ i % len ], d1[ i % len ], d2[ i % len ]);
	y = pdf( x[ i % len ], d1[ i % len ], d2[ i % len ] );

Uh oh!

Conversation

nirmaljb commented Feb 7, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Feb 7, 2026 •

edited

Loading