build: add weekly office hours workflow#121
Open
batpigandme wants to merge 3 commits intomainfrom
Open
Conversation
Assisted-by: claude-sonnet-4-6
kgryte
reviewed
May 5, 2026
kgryte
reviewed
May 5, 2026
kgryte
reviewed
May 5, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
May 5, 2026
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
This is great, @batpigandme. Main thing is that I think it would be better to move the Python logic to a separate script which is then called from the workflow. This would allow us to more readily lint, run locally, etc.
See https://github.com/stdlib-js/stdlib/tree/develop/.github/workflows for examples. There, we have a scripts/* directory which contains folders according to the workflow name and which contain any relevant scripts needed by that workflow.
Extract Python logic to script file. Add explicit permissions as is done in stdlib workflows. Assisted-by: claude-sonnet-4-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workflow to create new office hours issue every Tuesday.