Skip to content

feat(me): add batches to library (un)saving #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netlob wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(me): add batches to library (un)saving #64

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
721cc91
feat(me): add batches to library (un)saving
netlob Sep 7, 2024
07e7249
feat(me): prefer body instead of query
netlob Sep 7, 2024
49d13ed
style(me): use chunks for batch requests
netlob Sep 18, 2024
bcb7a03
fix(me): import chunk
netlob Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/lib/me/MeManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
Markets,
LibraryTrack
} from '../../interfaces/Spotify';
import { chunk } from '../../util/chunk';

import { Manager } from '../Manager';

Expand Down Expand Up @@ -142,19 +143,25 @@ export class MeManager extends Manager {
* @param {string} ids Array of IDs.
*/
async saveTracks(ids: string[]): Promise<void> {
await this.http.put(`/v1/me/tracks`, {
ids
});
// Use an async loop to preserve the order of saves
for (const chunkIds of chunk(ids, 50)) {
await this.http.put(`/v1/me/tracks`, {
ids: chunkIds
});
}
}

/**
* @description Remove multiple saved tracks by ID. (required scropes: user-library-read).
* @param {string} ids Array of IDs.
*/
async unsaveTracks(ids: string[]): Promise<void> {
await this.http.delete(`/v1/me/tracks`, {
query: { ids: ids.join(',') }
});
// Use an async loop to preserve the order of unsaves
for (const chunkIds of chunk(ids, 50)) {
await this.http.delete(`/v1/me/tracks`, {
ids: chunkIds
});
}
}

async playlists(options?: {
Expand Down