Skip to content

Fix code analysis not correctly detecting base types when inline constructors are used #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
girlpunk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix code analysis not correctly detecting base types when inline constructors are used #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/extensions/Statiq.CodeAnalysis/Analysis/AnalyzeSymbolVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ public AnalyzeSymbolVisitor(
// Get any reflected methods we need
Assembly workspacesAssembly = typeof(Workspace).Assembly;
Type reflectedType = workspacesAssembly.GetType("Microsoft.CodeAnalysis.Shared.Extensions.ITypeSymbolExtensions");
MethodInfo reflectedMethod = reflectedType.GetMethod("GetAccessibleMembersInThisAndBaseTypes");
MethodInfo reflectedMethod = reflectedType.GetRuntimeMethods().Single(m =>
m.Name.Equals("GetAccessibleMembersInThisAndBaseTypes") &&
m.GetParameters()[1].ParameterType == typeof(ISymbol));
_getAccessibleMembersInThisAndBaseTypes = reflectedMethod.MakeGenericMethod(typeof(ISymbol));

Assembly csharpAssembly = typeof(CSharpCompilation).Assembly;
Expand Down
3 changes: 2 additions & 1 deletion src/extensions/Statiq.CodeAnalysis/Statiq.CodeAnalysis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
<PackageTags>Statiq Static StaticContent StaticSite Blog BlogEngine CodeAnalysis Roslyn XmlDocComments DocComments</PackageTags>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Buildalyzer.Workspaces" Version="4.1.2" />
<PackageReference Include="Buildalyzer.Workspaces" Version="7.1.0" />
<PackageReference Include="NUnit3TestAdapter" Version="5.0.0" />
<PackageReference Include="System.Linq.Async" Version="6.0.1" />
</ItemGroup>
<ItemGroup>
Expand Down