[6.x] Fix date picker inconsistencies#14732
Merged
Merged
Conversation
…Trigger, which gave it a different focus ring/background than the date picker. It now matches the DatePicker for consistency
- Add `leading-[1.375rem]` to DatePicker container to fix vertical alignment and focused segment height - Remove `text-sm` and `antialiased` from DatePicker literal separators to fix thinner slashes/colons - Add `whitespace-pre` to literal separators in both pickers to preserve space in ", " separators - Reduce DatePicker segment padding from `px-0.5` to `px-0.25` to fix wider gaps between segments - Remove `py-2` and change `px-2.5` → `px-2` on DateRangePicker container to align with DatePicker - Change DateRangePicker trigger from `size-8 -ms-2` to `p-2 -ms-1` to match DatePicker sizing - Change DateRangePicker calendar icon from `size-3.5!` to `size-4` to match DatePicker Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
I added a little scope creep that made more things consistent between the single and range fields. |
jasonvarga
changed the title
jasonvarga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit by Jason:
The scope crept a little. I noticed some more inconsistencies between the single and range fields, so thought made sense to resolve them here. Things like padding, leading, spacing, etc.
Description of the Problem
Tiny thing, but the date range picker button is slightly different from the date picker button.
This is noticeable when escaping the date field
Escaping the date field
(desirable focus experience) – see the sidebar date field calendar icon, which just receives a gray background
Escaping the date range field
(undesirable focus experience) – see the sidebar date field calendar icon, which receives a wonky blue ring
What this PR Does
Fixes the date range calendar icon to use the same styling as the date field calendar icon, like this
(wonky blue focus line no longer visible)
How to Reproduce