[6.x] Fix Cached Pages count for multi-site setups#14726
Open
joshuablum wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cached pages count in the cache utility only includes URLs cached for the CP host site. Switching sites in the CP then shows a count of
0even when cached pages exist. This is not an issue for multi-sites using a single domain and directory structure (like/de,/fr...) but only when using different subdomains or entirely different domains.Fixing this by aggregating the URL/pages count across every cached domain returned by
AbstractCacher::getDomains()instead of relying on the implicit current domain. This gives a single global count of cached pages.