feat(py_common): Update py_common types to match Stash schema#2628
feat(py_common): Update py_common types to match Stash schema#2628feederbox826 merged 3 commits intostashapp:masterfrom
Conversation
Signed-off-by: xantror <69341873+xantror@users.noreply.github.com>
xantror
force-pushed
the
xantror/update-py_common_types
branch
from
aa8c77b to
a74b6bc
Compare
xantror
changed the title
|
don't add back url |
Signed-off-by: xantror <69341873+xantror@users.noreply.github.com>
Maista6969
left a comment
Maista6969
left a comment
There was a problem hiding this comment.
Looks good to me but I'm not sure if the stored_id fields should be included from the scraper side
| stored_id: str | ||
| "Set if performer matched" |
There was a problem hiding this comment.
What does this mean? Are there cases where scrapers do their own matching against Stash's database? I think this is an internal field that scrapers do not need to be concerned with
There was a problem hiding this comment.
The field is supported by Stash as far as I could see e.g. if somebody were to do some gql query to match within their scraper they could chose to return this field for a more exact match than what Stash might provide internally.
I don't think that any of the current scrapers use this functionality but who knows what people might need in the future.
…base64 options Signed-off-by: xantror <69341873+xantror@users.noreply.github.com>
feederbox826
left a comment
feederbox826
left a comment
There was a problem hiding this comment.
Long overdue but LGTM. I'll try to resolve some other PRs to avoid merge nightmares or just YOLO if I don't get to it in time
3 participants
Align py_common TypedDicts with Stash schema: add stored IDs, replace deprecated single url with urls, rename ScrapedMovie → ScrapedGroup, and remove deprecated fields.