Skip to content

integrate verify triple sum#432

Merged
Stavbe merged 1 commit intomainfrom
stav/integrate_verify_triple_sum
Apr 15, 2026
Merged

integrate verify triple sum#432
Stavbe merged 1 commit intomainfrom
stav/integrate_verify_triple_sum

Conversation

@Stavbe
Copy link
Copy Markdown
Collaborator

@Stavbe Stavbe commented Mar 26, 2026

Note

Medium Risk
Touches AIR constraint logic used for proving/verification; while the math is intended to be equivalent, any mismatch in input ordering or constraint wiring could break proof validity.

Overview
triple_sum_32 no longer inlines its carry computations; it now forwards the evaluated limbs/results into a new verify_triple_sum_32::accumulate_constraints helper.

Adds verify_triple_sum_32 modules in both cairo_air and circuit_air, centralizing the low/high carry range constraints (0/1/2) and updating the subroutine mod.rs exports accordingly.

Written by Cursor Bugbot for commit 968b6d7. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown
Collaborator Author

Stavbe commented Mar 26, 2026

@Stavbe Stavbe mentioned this pull request Mar 26, 2026
@reviewable-StarkWare
Copy link
Copy Markdown
Collaborator

This change is Reviewable

@Stavbe Stavbe marked this pull request as ready for review March 26, 2026 15:08
@Stavbe Stavbe self-assigned this Mar 26, 2026
@Stavbe Stavbe requested a review from anatgstarkware March 26, 2026 15:13
@Stavbe Stavbe force-pushed the stav/sync_air_infra branch from 831e98d to 6fb2fc2 Compare March 29, 2026 13:21
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from f446bb3 to 8155e72 Compare March 29, 2026 13:22
@Stavbe Stavbe force-pushed the stav/sync_air_infra branch from 6fb2fc2 to 5bf133c Compare March 29, 2026 13:48
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from 8155e72 to 53d8d6e Compare March 29, 2026 13:49
@Stavbe Stavbe force-pushed the stav/sync_air_infra branch from 5bf133c to 38e1b48 Compare March 31, 2026 07:51
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from 53d8d6e to 09fd3ac Compare March 31, 2026 07:51
@Stavbe Stavbe force-pushed the stav/sync_air_infra branch 3 times, most recently from bf52c9b to 8b04e92 Compare March 31, 2026 14:01
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from 09fd3ac to c166e18 Compare March 31, 2026 14:01
@Stavbe Stavbe force-pushed the stav/sync_air_infra branch from 8b04e92 to 67a19ea Compare March 31, 2026 16:11
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from c166e18 to 968b6d7 Compare March 31, 2026 16:11
@Stavbe Stavbe force-pushed the stav/sync_air_infra branch from 67a19ea to 348d51a Compare April 12, 2026 09:51
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from 968b6d7 to b9f2667 Compare April 12, 2026 09:51
@Stavbe Stavbe force-pushed the stav/sync_air_infra branch from 348d51a to 8389048 Compare April 14, 2026 13:49
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from b9f2667 to 7a6b1ca Compare April 14, 2026 13:49
@Stavbe Stavbe force-pushed the stav/sync_air_infra branch from 8389048 to 4539be8 Compare April 15, 2026 10:13
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from 7a6b1ca to e4ecbc3 Compare April 15, 2026 10:22
Copy link
Copy Markdown
Collaborator

@az-starkware az-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@az-starkware reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on anatgstarkware).

@Stavbe Stavbe changed the base branch from stav/sync_air_infra to main April 15, 2026 12:14
@Stavbe Stavbe force-pushed the stav/integrate_verify_triple_sum branch from e4ecbc3 to 8c90a87 Compare April 15, 2026 12:14
@Stavbe Stavbe merged commit 634bdaf into main Apr 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants