Conversation
e6e81be to
1f44a38
Compare
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on Gali-StarkWare).
crates/cairo_air/src/test.rs line 79 at r1 (raw file):
let proof_config = ProofConfig::from_components( &components, PreProcessedTrace::canonical_small().columns.len(),
I'd rather not have this in multiple places in the code, not that we want to evantually make it configurable.
Code quote:
PreProcessedTrace::canonical_small()
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on Gali-StarkWare and ilyalesokhin-starkware).
crates/cairo_air/src/test.rs line 79 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
I'd rather not have this in multiple places in the code, not that we want to evantually make it configurable.
Would you rather I re-export it in preprocessed_column?
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on Gali-StarkWare).
crates/cairo_air/src/test.rs line 79 at r1 (raw file):
Previously, Gali-StarkWare wrote…
Would you rather I re-export it in preprocessed_column?
You would still call it twice, right? What is the benefit?
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on Gali-StarkWare and ilyalesokhin-starkware).
crates/cairo_air/src/test.rs line 79 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
You would still call it twice, right? What is the benefit?
Yes. Right now we call it twice as well, we just call the constant..
|
Previously, Gali-StarkWare wrote…
a const is a const, you don't call it. |
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on ilyalesokhin-starkware).
gilbens-starkware
left a comment
There was a problem hiding this comment.
@gilbens-starkware made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on ilyalesokhin-starkware).
crates/cairo_air/src/test.rs line 79 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
a const is a const, you don't call it.
Ilya what what is your suggestion, wrapping it in a function?
|
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
I thought we could compute PreProcessedTrace::canonical_small() once here and then pass it to CairoVerifierConfig. |
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware reviewed 1 file.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on Gali-StarkWare).
|
Previously, ilyalesokhin-starkware wrote…
Maybe its better to have PreProcessedTraceVariant in the config: |

Note
Medium Risk
Swaps locally hardcoded preprocessed-column lists for
PreProcessedTrace::canonical_small(), which affects proof configuration sizing and the set/order of column IDs used during verification. If the upstream canonical list changes, proofs/configs could mismatch at runtime.Overview
Removes the in-crate hardcoded
CANONICAL_SMALL_PREPROCESSED_COLUMNSlist (and its test) and keeps onlyMAX_SEQUENCE_LOG_SIZE.Updates verifier configuration and statement logic (
privacy.rs,test.rs,statement.rs) to derive the preprocessed column count andPreProcessedColumnIds directly fromstwo_cairo_common::preprocessed_columns::preprocessed_trace::PreProcessedTrace::canonical_small()instead of the deleted local constant.Written by Cursor Bugbot for commit 1f44a38. This will update automatically on new commits. Configure here.