Skip to content

refactor: use named args shorthand#101

Merged
arad-starkware merged 1 commit intomainfrom
arad/refactor_use_named_args_shorthand
Mar 31, 2026
Merged

refactor: use named args shorthand#101
arad-starkware merged 1 commit intomainfrom
arad/refactor_use_named_args_shorthand

Conversation

@arad-starkware
Copy link
Copy Markdown
Collaborator

@arad-starkware arad-starkware commented Mar 22, 2026

This change is Reviewable


Note

Low Risk
Pure refactor of argument passing and struct field initialization in tests and one event emit call; no behavioral changes expected aside from potential compile-time syntax issues.

Overview
Refactors Cairo call sites across flow tests and unit tests to use the named-argument shorthand syntax (e.g., :amount, :staker_address, :pool_contract) for improved consistency and readability.

Also updates StakeOwnBalanceChanged event emission in staking.cairo to use the same shorthand when setting new_self_stake, without changing the underlying values.

Written by Cursor Bugbot for commit da8a83e. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arad-starkware arad-starkware self-assigned this Mar 22, 2026
@arad-starkware arad-starkware marked this pull request as ready for review March 22, 2026 12:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.80%. Comparing base (9c5b24f) to head (da8a83e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   95.80%   95.80%   -0.01%     
==========================================
  Files          43       43              
  Lines       10519    10517       -2     
==========================================
- Hits        10078    10076       -2     
  Misses        441      441              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noa-starkware).

@arad-starkware arad-starkware force-pushed the arad/refactor_use_named_args_shorthand branch from 917842b to da8a83e Compare March 31, 2026 08:31
Copy link
Copy Markdown
Collaborator Author

arad-starkware commented Mar 31, 2026

Merge activity

  • Mar 31, 8:31 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 31, 8:40 AM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'test / test').

@arad-starkware arad-starkware merged commit e29e2b7 into main Mar 31, 2026
9 of 11 checks passed
@arad-starkware arad-starkware deleted the arad/refactor_use_named_args_shorthand branch March 31, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants