Open
Conversation
Contributor
gilbens-starkware
left a comment
gilbens-starkware
left a comment
There was a problem hiding this comment.
@gilbens-starkware reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on anatgstarkware).
crates/privacy_circuit_verify/src/tests.rs line 86 at r1 (raw file):
+ CAIRO_PCS_CONFIG.fri_config.n_queries as u32 * CAIRO_PCS_CONFIG.fri_config.log_blowup_factor >= 96_u32,
Consider moving this and the one above to const/variable
Code quote:
96_u32,
gilbens-starkware
added a commit
that referenced
this pull request
Mar 19, 2026
- Add zstd compression to `privacy_prove` and `privacy_recursive_prove` outputs. - Decompress in `verify_cairo` and `verify_recursive_circuit`. - Add `MAX_RECURSIVE_PROOF_UNCOMPRESSED_BYTES` limit on the recursive decompression path to prevent zip-bomb attacks. - Extract `compress_proof` / `decompress_proof` helpers to keep prover and verifier functions symmetric. - Add `RECURSIVE_PROOF_UNCOMPRESSED_BYTES` constant (346,380 bytes) and a slow test that validates it against a real proof. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
gilbens-starkware
added a commit
that referenced
this pull request
Mar 19, 2026
* Compress proof output and add zip-bomb protection (#322) - Add zstd compression to `privacy_prove` and `privacy_recursive_prove` outputs. - Decompress in `verify_cairo` and `verify_recursive_circuit`. - Add `MAX_RECURSIVE_PROOF_UNCOMPRESSED_BYTES` limit on the recursive decompression path to prevent zip-bomb attacks. - Extract `compress_proof` / `decompress_proof` helpers to keep prover and verifier functions symmetric. - Add `RECURSIVE_PROOF_UNCOMPRESSED_BYTES` constant (346,380 bytes) and a slow test that validates it against a real proof. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add zip-bomb protection to verify_cairo - Add CAIRO_PROOF_UNCOMPRESSED_BYTES constant (621,432 bytes), validated by slow test check_max_cairo_proof_uncompressed_size. - Unify RECURSIVE_PROOF_MAX_DECOMPRESSED_RATIO into PROOF_MAX_DECOMPRESSED_RATIO shared by both paths. - Replace usize::MAX with MAX_CAIRO_PROOF_UNCOMPRESSED_BYTES in verify_cairo. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Breaking changes?
This change is