refactor(ap-change): remove unused tracking payload and redundant clones#9708
Open
Perekup1 wants to merge 1 commit intostarkware-libs:mainfrom
Open
refactor(ap-change): remove unused tracking payload and redundant clones#9708Perekup1 wants to merge 1 commit intostarkware-libs:mainfrom
Perekup1 wants to merge 1 commit intostarkware-libs:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
orizi
requested changes
Feb 24, 2026
Collaborator
orizi
left a comment
There was a problem hiding this comment.
@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Perekup1).
crates/cairo-lang-sierra-ap-change/src/compute.rs line 37 at r1 (raw file):
enum ApTrackingBase { FunctionStart(FunctionId), EnableStatement,
there on purpose - revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes strictly redundant code paths in AP change computation without changing behavior.
Removed unused payload from
ApTrackingBase::EnableStatement..cloned()with.copied()forOption<usize>values fetched from maps.ApChangeCalcHelper::newto returnSelfinstead ofResult<Self, ApChangeError>.calc_ap_changescall site to match the constructor signature.