Skip to content

Add compatibility of type aliases (Python 3.12+) to make_signature #9118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevapple wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Add compatibility of type aliases (Python 3.12+) to make_signature #9118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions dspy/signatures/signature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,11 @@ class MyType:
names = dict(typing.__dict__)
names.update(custom_types)

# Prepare accepted types for fields
known_types = (type, typing._GenericAlias, types.GenericAlias, typing._SpecialForm, types.UnionType)
if sys.version_info >= (3, 12):
known_types += (typing.TypeAliasType,)

fields = _parse_signature(signature, names) if isinstance(signature, str) else signature

# Validate the fields, this is important because we sometimes forget the
Expand All @@ -581,9 +586,7 @@ class MyType:
# program of thought and teleprompters, so we just silently default to string.
if type_ is None:
type_ = str
if not isinstance(
type_, (type, typing._GenericAlias, types.GenericAlias, typing._SpecialForm, types.UnionType)
):
if not isinstance(type_, known_types):
raise ValueError(f"Field types must be types, but received: {type_} of type {type(type_)}.")
if not isinstance(field, FieldInfo):
raise ValueError(f"Field values must be Field instances, but received: {field}.")
Expand Down