-
-
Notifications
You must be signed in to change notification settings - Fork 87
adding mcmc_dots and mcmc_dots_by_chain functions
#402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0fd6519 to
5a8f29f
Compare
|
Do you know why two of the new visual tests are failing? Maybe you just need to regenerate the snapshots? |
|
I just regenerated the SVGs and pushed them. Let's see if it passes now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 98.62% 98.64% +0.01%
==========================================
Files 35 35
Lines 5750 5811 +61
==========================================
+ Hits 5671 5732 +61
Misses 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sorry that I wasn't able to get back to this soon. In this commit, I attempted to re-run Now with your update, everything looks okay to me, and tests pass as well, so I'll mark this PR as ready. |
This PR adds
mcmc_dotsandmcmc_dots_by_chainfunctions which were requested by @avehtari.These functions are simply an adaptation of the previously implemented
ppc_dotsfunction to the MCMC space. Asppc_dotsdoes, these functions requireggdistto be installed, so it checks whether that is installed, and if it is, then it utilisesggdist::stat_dotsto create dot plots.Tasks:
Examples