feat(cli): add auto-update Cargo feature#675
Conversation
auto-update Cargo featureauto-update Cargo feature
|
So did you actually check if this PR works in the first place? because It doesn't |
Yes, I've tested that it a) successfully builds both with the new
Could you elaborate a bit more on what exactly is broken by this PR?
I don't have the rights to reopen the PR. |
|
@shehab299 My comment above still stands. Could we re-open this? |
|
I have built it myself and tested it still the ui for autoupdate shows up and it actually tries to update because the feature flag isn't applied to all places |
Add a new `auto-update` Cargo feature (default enabled) that controls whether the `stakpak update` subcommand and all auto-update behavior is compiled. When disabled, the `update` subcommand is removed from the CLI entirely, startup auto-update prompts are skipped, and forced auto-update in ACP mode is disabled. Co-authored-by: Copilot <copilot@github.com>
7c5e3a4 to
62b521e
Compare
I've rebased onto latest To test with the cargo install --locked --no-track --bins --features jemalloc --path cliTo test with the feature disabled I've built/installed with: cargo install --locked --no-track --bins --no-default-features --features bedrock,jemalloc --path cli
|
Add a new
auto-updateCargo feature (default enabled) that controls whether thestakpak updatesubcommand and all auto-update behavior is compiled. When disabled, theupdatesubcommand is removed from the CLI entirely, startup auto-update prompts are skipped, and forced auto-update in ACP mode is disabled.This allows to cleanly disable stakpak's self-update mechanism at build time for distribution channels where the feature is not wanted or can't possibly work.
Usage
Co-authored-by: Copilot copilot@github.com