Implement Privacy-Conscious Defaults#671
Open
sempervictus wants to merge 2 commits intostakpak:mainfrom
Open
Conversation
added 2 commits
March 26, 2026 21:37
All external communications now require explicit opt-in via environment variables as opposed to requiring users to find and explicitly apply opt-outs from data collection. Relevant for GRC concerns such as GDPR and other regional privacy regulations as well as basic user-retention/adoption - adress sentiment concern. Summary: - Auto-update checks blocked by default (requires `STAKPAK_ENABLE_UPDATES=1`) - Machine fingerprinting blocked by default (requires `STAKPAK_GENERATE_MACHINE_ID=1`) - Telemetry payload fields blocked individually (requires `STAKPAK_ENABLE_TELEMETRY=1` + per-field opts) - Fixed interactive mode telemetry bypass (`collect_telemetry.unwrap_or(false)`) Privacy Impact: - Zero external calls unless user explicitly opts in - No persistent machine identification without consent - Granular control over telemetry data fields - Sovereign workflow enforced by default
Allow users to specify a custom base URL for downloading rulebooks, skills, and playbooks. This enables private/internal repositories, custom CDNs, and air-gapped environments while maintaining full backward compatibility with Stakpak's default API. Changes: - New config field: rulebook_base_url (optional, defaults to api_endpoint) - New env var: STAKPAK_RULEBOOK_BASE_URL - Separate control plane (api_endpoint) from data plane (rulebook_base_url) - Backward compatible: defaults to https://apiv2.stakpak.dev if not set - All existing configs continue to work without modification Environment Variables: - STAKPAK_RULEBOOK_BASE_URL - Override rulebook base URL globally Config File Examples: [settings] rulebook_base_url = "https://rules.example.com" [profiles.corporate] rulebook_base_url = "http://local-rules:8080"
Collaborator
|
@sempervictus Thanks for the PR! I like the change. However, it includes two unrelated changes — could we split them into separate PRs so each one stays single-scoped |
Author
|
@ahmedhesham6 - happy to amend. What's out of scope? The two commits are intended to enable use for the all too popular "sovereign inference" use case. |
Collaborator
|
@sempervictus I mean the addition of the Rulebook URL its out of this scope |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce user opt-in for the significant data collection performed. Relevant to GDPR, CCPA, etc. There's no need to collect this much information about users and their activity unless they elect to have that information collected.