[DRAFT] Feature/add csi support#1073
Merged
faizanahmad055 merged 26 commits intomasterfrom Jan 8, 2026
Merged
Conversation
Signed-off-by: Zanis <22601571+ZanisO@users.noreply.github.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
faizanahmad055
changed the title
| return fmt.Sprintf("%x", sha) | ||
|
|
||
| hash := sha512.Sum512_256([]byte(data)) | ||
| return hex.EncodeToString(hash[:]) |
Contributor
There was a problem hiding this comment.
@faizanahmad055 This is a breaking change for people who are going to upgrade. It will cause all workloads that are managed by reloader to be restarted as it will notice a change in the last stored hash
Contributor
Author
There was a problem hiding this comment.
Yes indeed, I should have made this clear in the notes. The pipeline was previously failing because of critical vulnerability on SHA1 usage so I had to change it. We can discuss how to do it in a better way. May be do an announcement? But we will probably have to eventually do this change.
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
TheiLLeniumStudios
requested changes
Jan 6, 2026
Contributor
TheiLLeniumStudios
left a comment
TheiLLeniumStudios
left a comment
There was a problem hiding this comment.
Other than the above, 2 annotation override config flags are missing:
cmd.PersistentFlags().StringVar(&options.SecretProviderClassUpdateOnChangeAnnotation,
"secretproviderclass-annotation",
"secretproviderclass.reloader.stakater.com/reload",
"annotation to detect changes in secretproviderclasses, specified by name")
cmd.PersistentFlags().StringVar(&options.SecretProviderClassReloaderAutoAnnotation,
"secretproviderclass-auto-annotation",
"secretproviderclass.reloader.stakater.com/auto",
"annotation to detect changes in secretproviderclasses")
internal/pkg/util/util.go
Outdated
| cmd.PersistentFlags().BoolVar(&options.SyncAfterRestart, "sync-after-restart", false, "Sync add events after reloader restarts") | ||
| cmd.PersistentFlags().BoolVar(&options.EnablePProf, "enable-pprof", false, "Enable pprof for profiling") | ||
| cmd.PersistentFlags().StringVar(&options.PProfAddr, "pprof-addr", ":6060", "Address to start pprof server on. Default is :6060") | ||
| cmd.PersistentFlags().BoolVar(&options.EnableCSIIntegration, "enable-csi-integration", false, "Enables CSI integration. Default is :true") |
Contributor
There was a problem hiding this comment.
There's a typo here. Default value is false
internal/pkg/handler/upgrade.go
Outdated
| } | ||
|
|
||
| func populateAnnotationsFromSecretProviderClass(clients kube.Clients, config *common.Config) { | ||
| obj, err := clients.CSIClient.SecretsstoreV1().SecretProviderClasses(config.Namespace).Get(context.TODO(), config.ResourceName, metav1.GetOptions{}) |
Contributor
There was a problem hiding this comment.
Use a background context
internal/pkg/handler/upgrade.go
Outdated
| } | ||
|
|
||
| func secretProviderClassAnnotationReloaded(oldAnnotations map[string]string, newConfig common.Config) bool { | ||
| annotaion := oldAnnotations[getReloaderAnnotationKey()] |
Contributor
There was a problem hiding this comment.
A typo here.. Should be annotation
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
faizanahmad055
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.