Add GPU timestamp queries for per-pass profiling#153
Merged
Conversation
Extend the RHI with QuerySet, timestamp query methods, and copy_buffer_to_buffer so the renderer can measure per-pass GPU time via wgpu timestamp queries. The CPU Profiler now distinguishes Cpu vs Gpu sections and GPU timings appear in the same frame summary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying euca-engine with
|
| Latest commit: |
1308d28
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07ef2109.euca-engine.pages.dev |
| Branch Preview URL: | https://gpu-timestamp-queries.euca-engine.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuerySet,create_query_set,resolve_query_set,timestamp_period_ns,read_timestamp_buffer, andcopy_buffer_to_buffermethodsProfileSectionKind(Cpu/Gpu) to the profiler so GPU and CPU timings coexist inframe_summary()GpuTimerStateto the renderer with 1-frame-delayed readback (shadow + PBR passes instrumented)supports_timestamp_queriestoHardwareSurveyandtimestamp_querytoCapabilitiesQuerySet = ()with no-op defaultsTest plan
cargo test --workspace-- all tests pass (including 3 new profiler tests)cargo clippy --workspace -- -D warnings-- zero warningscargo fmt --all -- --check-- formatted🤖 Generated with Claude Code