Add CI benchmark regression detection for PRs#147
Merged
Conversation
The bench job previously only ran on push to main, accumulating criterion artifacts without comparison. This adds a dual-mode workflow: on push to main it saves the baseline to cache, and on PRs it restores the baseline, runs benchmarks, compares via critcmp, posts results as a PR comment, and fails if any benchmark regresses by more than 10%. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying euca-engine with
|
| Latest commit: |
ddbbdf4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f1848df4.euca-engine.pages.dev |
| Branch Preview URL: | https://ci-bench-regression-detectio.euca-engine.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchjob so it runs on both push to main and pull requestscritcmp, posts a formatted comparison as a PR comment, and fails the job if any benchmark regresses by more than 10%Test plan
python3 -c "import yaml; yaml.safe_load(...)")cargo check --workspacepasses (done locally, clean build).github/workflows/ci.yml)🤖 Generated with Claude Code