Wire terrain_panel into editor and fix clippy warnings#144
Merged
Conversation
Add the terrain brush panel to the editor's egui layout so it renders alongside the inspector when not in play mode. Also resolve all clippy collapsible_if warnings by using Rust 2024 let-chains, and remove an unnecessary f32-to-f32 cast in world_dt. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying euca-engine with
|
| Latest commit: |
d30d119
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23d84ed8.euca-engine.pages.dev |
| Branch Preview URL: | https://unit4-test-fix-editor.euca-engine.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terrain_panelfunction into the editor example's egui layout, rendering it alongside the inspector panel when not in play modeexamples/editor.rs: 8 collapsible-if violations refactored to use Rust 2024 let-chains, and 1 unnecessaryf32-to-f32cast removedcargo check --workspace,cargo test --workspace,cargo clippy --workspace -- -D warnings,cargo fmt --all -- --check,cargo build --release -p euca-editor --example editorTest plan
cargo check --workspacepassescargo test --workspacepasses (all 1600+ tests, 0 failures)cargo clippy --workspace -- -D warningspassescargo fmt --all -- --checkpassescargo build --release -p euca-editor --example editorsucceedscargo test -p euca-editorpasses (17 tests)🤖 Generated with Claude Code