Wire MetalFX temporal upscaling into Renderer#143
Merged
Conversation
Add optional MetalFX support to the generic Renderer<D>: - `metalfx_enabled` field (stored on all backends, no-op on wgpu) - `enable_metalfx` / `is_metalfx_enabled` methods on generic impl - `setup_metalfx_upscaling` / `resize_metalfx` on Metal-native impl (cfg-gated behind target_os = "macos" + feature = "metal-native") - `supports_metalfx` capability query on GpuContext<MetalDevice> The Metal-native impl validates upscaler creation and documents the full integration path (render PBR at 50% res, upscale, feed into post-process ping buffer) for a follow-up. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying euca-engine with
|
| Latest commit: |
c68eb96
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ac4ffa8.euca-engine.pages.dev |
| Branch Preview URL: | https://worktree-agent-a8ab615a.euca-engine.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metalfx_enabledfield andenable_metalfx/is_metalfx_enabledmethods to the genericRenderer<D>(no-op on wgpu, active on Metal)impl Renderer<MetalDevice>withsetup_metalfx_upscalingandresize_metalfxthat validate MetalFX upscaler creationsupports_metalfxcapability query onGpuContext<MetalDevice>Test plan
cargo check --workspace(wgpu path)cargo check -p euca-render --features metal-native(Metal path)cargo test --workspace(all pass)cargo clippy --workspace -- -D warnings(clean)cargo fmt --all -- --check(clean)🤖 Generated with Claude Code