remove duplicate value/result from observer events and block replay r…#6954
Conversation
federico-stacks
left a comment
There was a problem hiding this comment.
lgtm!
just a question: have we already notified our users about this breaking change?
We should have done that already, but it's worth double checking before merging |
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (81.08%) is below the adjusted base coverage (84.99%). You can increase the head coverage or adjust the Removed Code Behavior. Additional details and impacted files@@ Coverage Diff @@
## develop #6954 +/- ##
===========================================
- Coverage 84.99% 81.08% -3.92%
===========================================
Files 412 412
Lines 219958 220016 +58
Branches 338 338
===========================================
- Hits 186959 178403 -8556
- Misses 32999 41613 +8614
... and 178 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Remove redundant fields from observer/RPC event payloads:
valuefrom NFT (transfer, mint, burn) and SmartContract event JSONraw_value(hex-encoded Clarity value)resultfrom block replay/simulate transaction responsesresult_hex(hex-encoded Clarity value)Applicable issues
Additional info (benefits, drawbacks, caveats)
Both pairs contained the same underlying Clarity
Valueserialized differently; The hex variants are smaller and trivially parseable in Rust and TypeScript/JavaScript.Breaking change: event observers consuming value from NFT/contract events or result from replay/simulate responses must switch to
raw_value/result_hexrespectively.Checklist
docs/property-testing.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo