improve grcov '--ignore' globs#109
Merged
cylewitruk-stacks merged 1 commit intostacks-network:mainfrom Mar 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the grcov ignore globs used by the composite GitHub Action to more precisely exclude test-related paths/files (and avoid over-matching), improving coverage signal quality for the Stacks codebases that use this action.
Changes:
- Simplifies directory ignore globs from
**/*forms to**. - Attempts to consolidate
test/testsignores usingtest{,s}brace syntax. - Replaces a broad
*tests.rsignore with more targeted*_test{,s}.rs-style patterns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve grcov
--ignoreglob patterns:**instead of redundant**/*(globsetdocs say**matches zero or more path segments, including files).test{,s}to consolidatetest/testsmatching into single patterns (current pattern missesstackslib/chainstate/stacks/index/test/**, e.g. in perf: add small root-node LRU cache for MARF storage connections stacks-core#6944).**/*_test{,s}.rspattern to catch suffixed test files (e.g.foo_test.rs/bar_tests.rs) without over-matching (the previous**/*tests.rsglob could match potential non-test files likecontest.rs).