Skip to content

improve grcov '--ignore' globs#109

Merged
cylewitruk-stacks merged 1 commit intostacks-network:mainfrom
cylewitruk-stacks:grcov/ignore-test-and-tests-directories
Mar 2, 2026
Merged

improve grcov '--ignore' globs#109
cylewitruk-stacks merged 1 commit intostacks-network:mainfrom
cylewitruk-stacks:grcov/ignore-test-and-tests-directories

Conversation

@cylewitruk-stacks
Copy link
Copy Markdown
Contributor

@cylewitruk-stacks cylewitruk-stacks commented Mar 2, 2026

Improve grcov --ignore glob patterns:

  • Use ** instead of redundant **/* (globset docs say ** matches zero or more path segments, including files).
  • Use brace expansion test{,s} to consolidate test/tests matching into single patterns (current pattern misses stackslib/chainstate/stacks/index/test/**, e.g. in perf: add small root-node LRU cache for MARF storage connections stacks-core#6944).
  • Add separate **/*_test{,s}.rs pattern to catch suffixed test files (e.g. foo_test.rs/bar_tests.rs) without over-matching (the previous **/*tests.rs glob could match potential non-test files like contest.rs).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the grcov ignore globs used by the composite GitHub Action to more precisely exclude test-related paths/files (and avoid over-matching), improving coverage signal quality for the Stacks codebases that use this action.

Changes:

  • Simplifies directory ignore globs from **/* forms to **.
  • Attempts to consolidate test/tests ignores using test{,s} brace syntax.
  • Replaces a broad *tests.rs ignore with more targeted *_test{,s}.rs-style patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread codecov/action.yml
Copy link
Copy Markdown
Contributor

@dhaney-stacks dhaney-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 🚢 it!

@cylewitruk-stacks cylewitruk-stacks merged commit c4a0ff6 into stacks-network:main Mar 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants