ROX-34553: Render resourceScope in table of ConfigReportsTab#20368
Open
pedrottimark wants to merge 1 commit intomasterfrom
Open
ROX-34553: Render resourceScope in table of ConfigReportsTab#20368pedrottimark wants to merge 1 commit intomasterfrom
pedrottimark wants to merge 1 commit intomasterfrom
Conversation
Contributor
🚀 Build Images ReadyImages are ready for commit 84120f0. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-867-g84120f0a3c |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20368 +/- ##
==========================================
+ Coverage 49.56% 49.58% +0.02%
==========================================
Files 2794 2797 +3
Lines 212518 212766 +248
==========================================
+ Hits 105331 105509 +178
- Misses 99453 99524 +71
+ Partials 7734 7733 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review: Hide space because of indentation changes.
Objective
Provide equivalent filter for scheduled reports as view-based reports
Problem
If you create image report configuration with entity (instead of collection) scope,
COnfigReportsTabcrashes, as expected.Analysis
ConfigReportsTab.tsx file renders Collection and assumes collection scope:
Solution
Edit ConfigReportsTab.tsx file.
Edit reportsTable.test.js file.
Edit ViewBasedReportsTab.tsx and VulnReportingLayout.tsx files.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with staging demo as central.Manual testing
Visit /main/vulnerabilities/reports/configuration and click link for report configuration that has collection scope.
Original unconditional code:

Replaced conditional code:

Temporarily edit code to add report configuration that has entity scope.
Original unconditional code:

Replaced conditional code:

Click Resources link that has collection scope.
Replaced conditional code:
