Improve Metadata Comparison #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceVersion, but also a few other fields managed by the cluster
mclasmeier
force-pushed
the
mc/metadata-comparison
branch
from
6c22a7c to
e9f1f03
Compare
porridge
approved these changes
Dec 8, 2025
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Most importantly, we not only exclude
resourceVersionfrom the equality check, but alsomanagedFields-- it unnecessarily prevents conflict resolution in RHACS operator in real-world situations, which causes repeated reconciliation attempts and multiple errors being logged.