Do not ever update the status in case the generation has changed #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this, because the status of RHACS operator includes an "observedGeneration".
The helm-operator prior this change would happily refresh the object and a status updater function registered by the RHACS operator would then happily copy over the
metadata.generationto thestatus.observedGenerationfield. This can happen, if, for example, the user fiddles around with the CR spec while the helm-operator does its reconciliation. In the end we would end up with an inconsistency: updatedobservedGenerationeven though that is not the generation corresponding to thespecwhich was reconciled.