Remove Amp editor extension clients#5717
Open
ecgang wants to merge 1 commit into
Open
Conversation
Amp discontinued their VS Code / Cursor / Windsurf editor extensions, so the
corresponding ToolHive clients targeted software that no longer exists. Remove
the four dead client identifiers:
- amp-vscode
- amp-vscode-insider
- amp-cursor
- amp-windsurf
amp-cli is retained: Amp still ships and supports the CLI.
Removed the ClientApp constants and their registry entries in
pkg/client/config.go, the corresponding mock registry / switch / assertion
references in pkg/client/config_test.go, and the stale test-data strings in
pkg/config/config_test.go. Regenerated (by hand, matching codegen output) the
swaggo enums (docs/server/{docs.go,swagger.json,swagger.yaml}) and the cobra
client-list docs (docs/cli/thv_client_{register,remove}.md); `make docs` should
be re-run to confirm byte-for-byte.
BREAKING CHANGE: the amp-vscode, amp-vscode-insider, amp-cursor, and
amp-windsurf client identifiers are removed from the MCP ClientApp API enum.
Closes stacklok#5675
ecgang
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
aponcedeleonch,
jhrozek,
lujunsan,
rdimitrov and
reyortiz3
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5717 +/- ##
==========================================
- Coverage 70.65% 70.63% -0.03%
==========================================
Files 682 682
Lines 68854 68854
==========================================
- Hits 48651 48636 -15
- Misses 16657 16668 +11
- Partials 3546 3550 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@ecgang Can you comment on #5675 requesting assignment, per the contributor guidelines? https://github.com/stacklok/toolhive/blob/main/CONTRIBUTING.md#claiming-an-issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5675
This contribution was developed with AI assistance via terminalhire. The author has reviewed the change and takes responsibility for its content.