docs: remove stale chart version bump guidance from check-contribution skill#5211
Open
wucm667 wants to merge 1 commit intostacklok:mainfrom
Open
docs: remove stale chart version bump guidance from check-contribution skill#5211wucm667 wants to merge 1 commit intostacklok:mainfrom
wucm667 wants to merge 1 commit intostacklok:mainfrom
Conversation
…n skill The check-contribution SKILL.md instructed contributors to bump Chart.yaml versions in feature PRs, but this has been fully delegated to release automation (create-release-pr.yml). Feature PRs should not modify Chart.yaml; version bumps are now bot-driven. Closes stacklok#5095
wucm667
requested review from
JAORMX,
jerm-dro,
jhrozek and
rdimitrov
as code owners
github-actions
Bot
added
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5211 +/- ##
==========================================
- Coverage 67.78% 67.73% -0.05%
==========================================
Files 608 608
Lines 62212 62212
==========================================
- Hits 42172 42141 -31
- Misses 16866 16896 +30
- Partials 3174 3175 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
.claude/skills/check-contribution/SKILL.mdskill has been instructing contributors (and AI agents) to verify thatChart.yamlversions are bumped in feature PRs. This guidance is stale — chart version bumping is now fully automated by the release bot via.github/workflows/create-release-pr.yml. Feature PRs should not modifyChart.yaml.What changed:
Chart.yamlFixes #5095
Type of change
Test plan
task test)task test-e2e)task lint-fix)API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Does this introduce a user-facing change?
No.