Skip to content

Support proxy_port from registry for remote servers#4039

Open
rdimitrov wants to merge 6 commits intomainfrom
add-proxy
Open

Support proxy_port from registry for remote servers#4039
rdimitrov wants to merge 6 commits intomainfrom
add-proxy

Conversation

@rdimitrov
Copy link
Member

Summary

The following PR:

  • Add WithRegistryProxyPort option to the run config builder
  • Wire it up in both CLI (configureRemoteAuth) and API paths

Fixes stacklok/toolhive-core#54

In draft until the other change on toolhive-core is merged

Type of change

  • Bug fix
  • New feature
  • Refactoring (no behavior change)
  • Dependency update
  • Documentation
  • Other (describe):

Test plan

  • Unit tests (task test)
  • E2E tests (task test-e2e)
  • Linting (task lint-fix)
  • Manual testing (describe below)

Changes

File Change

Does this introduce a user-facing change?

Special notes for reviewers

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Mar 6, 2026
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov marked this pull request as ready for review March 6, 2026 22:06
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Mar 6, 2026
reyortiz3
reyortiz3 previously approved these changes Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.61%. Comparing base (c3aeb02) to head (154cbc8).

Files with missing lines Patch % Lines
pkg/runner/config_builder.go 0.00% 6 Missing and 1 partial ⚠️
pkg/api/v1/workload_service.go 20.00% 3 Missing and 1 partial ⚠️
pkg/authserver/server/handlers/callback.go 50.00% 1 Missing ⚠️
pkg/authz/response_filter.go 66.66% 1 Missing ⚠️
pkg/container/images/registry.go 0.00% 1 Missing ⚠️
pkg/transport/stdio.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4039      +/-   ##
==========================================
- Coverage   68.70%   68.61%   -0.09%     
==========================================
  Files         445      445              
  Lines       45374    45386      +12     
==========================================
- Hits        31173    31142      -31     
- Misses      11796    11840      +44     
+ Partials     2405     2404       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lujunsan
lujunsan previously approved these changes Mar 6, 2026
amirejaz
amirejaz previously approved these changes Mar 6, 2026
Copy link
Contributor

@amirejaz amirejaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one nit

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov dismissed stale reviews from amirejaz, lujunsan, and reyortiz3 via 51c0028 March 6, 2026 22:56
@rdimitrov rdimitrov requested review from blkt and jerm-dro as code owners March 6, 2026 22:56
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Mar 6, 2026
Copy link
Contributor

@amirejaz amirejaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added another comment, sorry for fragmented review

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Mar 6, 2026
@amirejaz
Copy link
Contributor

amirejaz commented Mar 6, 2026

@rdimitrov Approved from my side, need to fix the linter errors.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proxy_port field missing from remote server registry schema

4 participants