Conversation
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
reyortiz3
previously approved these changes
Mar 6, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4039 +/- ##
==========================================
- Coverage 68.70% 68.61% -0.09%
==========================================
Files 445 445
Lines 45374 45386 +12
==========================================
- Hits 31173 31142 -31
- Misses 11796 11840 +44
+ Partials 2405 2404 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lujunsan
previously approved these changes
Mar 6, 2026
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
amirejaz
reviewed
Mar 6, 2026
Contributor
amirejaz
left a comment
There was a problem hiding this comment.
added another comment, sorry for fragmented review
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Contributor
|
@rdimitrov Approved from my side, need to fix the linter errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following PR:
WithRegistryProxyPortoption to the run config builderconfigureRemoteAuth) and API pathsFixes stacklok/toolhive-core#54
In draft until the other change on toolhive-core is merged
Type of change
Test plan
task test)task test-e2e)task lint-fix)Changes
Does this introduce a user-facing change?
Special notes for reviewers