Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Dec 18, 2025

Integrates the health monitoring infrastructure (from previous into the vMCP server, enabling periodic backend health checks with configurable intervals and thresholds.

Related-to: #3036

@github-actions github-actions bot added the size/M Medium PR: 300-599 lines changed label Dec 18, 2025
@yrobla yrobla requested a review from Copilot December 18, 2025 15:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates health monitoring infrastructure into the vMCP server to enable periodic backend health checks with configurable intervals and thresholds. The implementation provides a new HTTP endpoint for querying backend health status, graceful degradation when health monitoring fails, and authentication bypass for health check requests.

Key Changes:

  • Added health monitor lifecycle management (initialization, startup, and shutdown) in the vMCP server
  • Introduced /api/backends/health HTTP endpoint to expose backend health status
  • Updated authentication strategies to skip authentication for health check requests

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pkg/vmcp/server/server.go Integrates health monitor into server lifecycle with configuration, initialization, start/stop management, new HTTP endpoint handler, and getter methods for health status
pkg/vmcp/server/health_monitoring_test.go Comprehensive test coverage for health monitoring scenarios including disabled/enabled states, startup failures, HTTP endpoint behavior, and lifecycle management
pkg/vmcp/auth/strategies/tokenexchange.go Updates token exchange authentication strategy to skip authentication for health check requests using context marker
pkg/vmcp/auth/strategies/header_injection.go Updates header injection authentication strategy to skip authentication for health check requests using context marker
cmd/vmcp/app/commands.go Configures health monitor from operational settings, mapping HealthCheckInterval and UnhealthyThreshold to health.MonitorConfig

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/M Medium PR: 300-599 lines changed labels Dec 18, 2025
@yrobla yrobla force-pushed the feat/issue-3036-healthcheck-2 branch from 80eaf93 to 6a3fcae Compare December 19, 2025 08:32
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 68.69565% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.16%. Comparing base (d55f7ec) to head (7c0cd81).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
cmd/vmcp/app/commands.go 0.00% 22 Missing ⚠️
pkg/vmcp/server/server.go 82.50% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3101      +/-   ##
==========================================
+ Coverage   57.11%   57.16%   +0.05%     
==========================================
  Files         341      341              
  Lines       33949    34053     +104     
==========================================
+ Hits        19389    19468      +79     
- Misses      12951    12972      +21     
- Partials     1609     1613       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from feat/issue-3036-healthcheck-1 to main December 19, 2025 14:49
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 19, 2025
@yrobla yrobla requested a review from Copilot December 19, 2025 15:04
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 19, 2025
@yrobla yrobla force-pushed the feat/issue-3036-healthcheck-2 branch from a4eedc5 to 95dba05 Compare December 19, 2025 15:37
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 19, 2025
@yrobla yrobla requested a review from Copilot December 19, 2025 15:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yrobla yrobla force-pushed the feat/issue-3036-healthcheck-2 branch from 95dba05 to 1851665 Compare December 22, 2025 08:09
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 22, 2025
author taskbot <taskbot@users.noreply.github.com> 1766072123 +0100
committer taskbot <taskbot@users.noreply.github.com> 1766158585 +0100

Integrate health monitoring into vMCP server

Integrates the health monitoring infrastructure (from previous into
the vMCP server, enabling periodic backend health checks with configurable
Related-to: #3036

  intervals and thresholds.

changes from review

changes from review

add missing method

Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@yrobla yrobla force-pushed the feat/issue-3036-healthcheck-2 branch from 1851665 to 0c290a9 Compare December 22, 2025 10:20
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 22, 2025
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 22, 2025
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 23, 2025
@yrobla yrobla merged commit 4b3fd00 into main Dec 23, 2025
33 checks passed
@yrobla yrobla deleted the feat/issue-3036-healthcheck-2 branch December 23, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Large PR: 600-999 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants