Remove factory for RegistryDataProvider #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code previously had a factory for the RegistryDataProvider interface which had stubbed out logic for returning an implementation of this type backed by a database. In practice, this interface was not useful when we added the DB, and so only the file-based implementation is needed. This PR: 1) Gets rid of the factory. The application wireup code calls the factory method of the file-based implementation directly when wiring up a file-backed instance of the server. 2) Moves the file-based implementation and the interface under the inmemory package to make it clear that it is only relevant for the file-based storage logic. In future, we may refactor the code to remove this interface entirely.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 61.66% 61.81% +0.15%
==========================================
Files 69 67 -2
Lines 5882 5848 -34
==========================================
- Hits 3627 3615 -12
+ Misses 2012 1991 -21
+ Partials 243 242 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blkt
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code previously had a factory for the
RegistryDataProviderinterface, which had stubbed out logic for returning an implementation of this type backed by a database. In practice, this interface was not useful when we added the DB, and so only the file-based implementation is needed.This PR:
factory method of the file-based implementation directly when wiring
up a file-backed instance of the server.
inmemory package to make it clear that it is only relevant for the
file-based storage logic.
In future, we may refactor the code to remove this interface entirely.