Skip to content

Conversation

@dmjb
Copy link
Member

@dmjb dmjb commented Dec 10, 2025

This adds a field to the DB (and a field to the status file) which
tracks whether a registry was created through the API or through the
config file. The code for initialization sets the type to config for
now, and ensures that the initialization process does not touch any
registries created through the API.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 50.31056% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.76%. Comparing base (0149b0b) to head (c1c1429).

Files with missing lines Patch % Lines
database/testcontainers.go 0.00% 25 Missing ⚠️
internal/sync/state/db.go 0.00% 21 Missing ⚠️
internal/db/sqlc/models.go 26.31% 14 Missing ⚠️
internal/sync/state/file.go 76.00% 8 Missing and 4 partials ⚠️
internal/db/sqlc/registry.sql.go 79.41% 4 Missing and 3 partials ⚠️
internal/app/builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   61.66%   61.76%   +0.10%     
==========================================
  Files          69       69              
  Lines        5882     6023     +141     
==========================================
+ Hits         3627     3720      +93     
- Misses       2012     2050      +38     
- Partials      243      253      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmjb dmjb changed the title [DO NOT MERGE] Track "creation type" for each registry. Track "creation type" for each registry. Dec 10, 2025
This adds a field to the DB (and a field to the status file) which
tracks whether a registry was created through the API or through the
config file. The code for initialization sets the type to config for
now, and ensures that the initialization process does not touch any
registries created through the API.
@dmjb dmjb force-pushed the registry-creation-tracking branch from f7e84bc to 53e5433 Compare December 10, 2025 17:04
@dmjb dmjb marked this pull request as ready for review December 10, 2025 17:05
Copy link
Member

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dmjb dmjb changed the title Track "creation type" for each registry. Track "creation type" for each registry Dec 11, 2025
@dmjb dmjb merged commit 5f80fad into main Dec 11, 2025
11 checks passed
@dmjb dmjb deleted the registry-creation-tracking branch December 11, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants