Simplify public API for the verifier and improve error handling#35
Merged
Simplify public API for the verifier and improve error handling#35
Conversation
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
changed the title
JAORMX
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR:
verifier.Newandverifier.VerifyServernow accept*registry.Provenancedirectly instead of*registry.ImageMetadata, removing unnecessary coupling to the registry-specific structVerifyServernow returnserrorinstead of(bool, error)— callers useerrors.Isto distinguish outcomesErrImageNotSignedandErrProvenanceMismatchso callers can tell apart an unsigned image from a provenance mismatchVerifyServernow uses any-match semantics: returnsnilif at least one bundle matches the expected provenance, rather than requiring all bundles to match