fix: exclude static assets from middleware matcher#510
Open
fix: exclude static assets from middleware matcher#510
Conversation
The proxy middleware intercepted requests to public static files (e.g. /bg-pattern.png on the signin page), causing a broken image icon. Extend the matcher regex to skip common image extensions. Backport of stacklok/stacklok-enterprise-platform#746. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Next.js middleware matcher to prevent the proxy middleware from running on public image assets, fixing broken static images on routes like /signin (e.g. /bg-pattern.png).
Changes:
- Extend the middleware
matchernegative-lookahead to exclude common image extensions (svg,png,jpg,jpeg,gif,webp). - Escape
favicon.icoin the matcher regex for literal matching.
Transitive dep ip-address@10.1.0 (via @modelcontextprotocol/sdk → express-rate-limit) has a medium severity vulnerability. Override to >=10.1.1 resolves the Grype and pnpm audit failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
size/XS
samuv
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/bg-pattern.pngon the sign-in page), causing a broken image icon in the top-left corner.svg,.png,.jpg,.jpeg,.gif,.webp)Test plan
pnpm dev) and navigate to/signinbg-pattern.pngloads correctly (no broken image icon)toolhive-logo.svgrenders on both mobile and desktop layouts🤖 Generated with Claude Code