-
Notifications
You must be signed in to change notification settings - Fork 2
Add docs about Registry deployment via Operator #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| ## Overview | ||
|
|
||
| The ToolHive operator deploys the Registry server in Kubernetes by creating | ||
| `MCPRegistry` resources. This is the recommended method for deploying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to say that its the recommended way. We probably should have a discussion about what we recommend. Personally, I'd recommend a helm chart installation over an Operator one. But I'd like to get others opinions on this.
|
|
||
| ## Create a registry | ||
|
|
||
| You can create `MCPRegistry` resources in namespaces based on how the operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You can create `MCPRegistry` resources in namespaces based on how the operator | |
| You can create `MCPRegistry` resources in the namespaces where the ToolHive Operator is deployed |
| You can create `MCPRegistry` resources in namespaces based on how the operator | ||
| was deployed. | ||
|
|
||
| - **Cluster mode (default)**: Create MCPRegistry resources in any namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have multi-tenanted support for the registry yet - only operator installation and MCP server installation. Currently it is only scoped to the namespace it is installed in
|
|
||
| When customizing containers in `podTemplateSpec`, you must use | ||
| `name: registry-api` for the main container to ensure the operator can properly | ||
| manage the Registry server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| manage the Registry server. | |
| manage the Registry server. The container name is hardcoded to avoid conflict issues with user provided containers. Mandating a container name on the Operator side explicitly tells the Operator it is the main registry server container and any other containers provided by the use are sidecars/init containers. |
|
@ChrisJBurns thanks for the review, I should have addressed all your comments, PTAL. |
This change adds how to use the Operator to deploy a Registry Server instance. Specifically, documentation under `docs/toolhive/guides-registry` only mentions that you can use the Operator to deploy a Registry Server instance and links back to a page under `docs/toolhive/guides-k8s` containing all the documentation. Documentation about using Postgres password file is not there because we're working to make that transparent to the User. I left documentation using plain Kubernetes resources untouched in the `docs/toolhive/guides-registry` guide.
431ed5d to
e95c212
Compare
Description
This change adds how to use the Operator to deploy a Registry Server instance. Specifically, documentation under
docs/toolhive/guides-registryonly mentions that you can use the Operator to deploy a Registry Server instance and links back to a page underdocs/toolhive/guides-k8scontaining all the documentation.Documentation about using Postgres password file is not there because we're working to make that transparent to the User.
I left documentation using plain Kubernetes resources untouched in the
docs/toolhive/guides-registryguide.Type of change
Related issues/PRs
Submitter checklist
Content and formatting
Navigation
sidebars.ts) updated for added, deleted, reordered, or renamed filesvercel.jsonfor moved, renamed, or deleted pages (i.e., if the URL slug changed)Reviewer checklist
Content