refactor!: helmchart simple #174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ployment templates
…h Kustomize and Tilt
…t production secret management
…oduction secret management
…pdate related configurations
…or improved secret management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors secret management and environment variable handling across the local development and deployment workflow, focusing on improving flexibility and security. The changes standardize secret references, introduce dev-only helpers for Langfuse initialization, and update documentation and templates to reflect the new structure. The most important changes are grouped below:
Secret Management Refactor
secretKeyRefinvalues.yamland Helm templates. This enables easier integration with external secret managers and more granular secret configuration. (.env.template,Tiltfile,infrastructure/README.md,README.md, [1] [2] [3] [4] [5] [6] [7] F9cc2a25L27R29)secretKeyRef.namewhen set, and falling back to default names. This affects backend/admin deployments and ingress authentication. (infrastructure/rag/templates/_admin_backend_and_extractor_helpers.tpl,infrastructure/rag/templates/_backend_helpers.tpl, [1] [2] [3] [4] [5]Langfuse Dev-Only Helper
.env.langfusefile, which is used to generate a stable Kubernetes secret for local development. Documentation and Tiltfile logic were updated to support this workflow. (infrastructure/kustomize/langfuse/.env.langfuse.template,infrastructure/kustomize/langfuse/kustomization.yaml,Tiltfile,README.md,infrastructure/README.md, [1] [2] [3] [4] [5]Documentation Updates
README.mdandinfrastructure/README.mdto reflect the new environment variable and secret structure, clarify dev/prod secret management, and provide step-by-step instructions for local setup and deployment. (README.md,infrastructure/README.md, [1] [2] [3] [4] [5] [6]Configuration and Template Changes
infrastructure/README.md,infrastructure/rag/templates/_admin_backend_and_extractor_helpers.tpl,infrastructure/rag/templates/_backend_helpers.tpl, [1] [2]Minor Improvements
infrastructure/README.md, infrastructure/README.mdL313-R353)Let me know if you need more details about any specific change or how these updates affect your workflow!