Bump stackhpc-openstack-gh-workflows to 1.5.0 #2027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Alex-Welsh
requested changes
Dec 8, 2025
Member
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
Will fail on major upgrade if previous version is undefined. You'll need to update multinode-inputs.py
Member
Author
|
Oops |
seunghun1ee
force-pushed
the
bump-multinode-workflow
branch
from
0aab73f to
35eff5b
Compare
Alex-Welsh
force-pushed
the
bump-multinode-workflow
branch
from
35eff5b to
d67e196
Compare
Alex-Welsh
force-pushed
the
bump-multinode-workflow
branch
from
d67e196 to
bf469d4
Compare
To make upgrading tests to work with new versioned terraform-kayobe-multinode branches. New workflow variable ``terraform_kayobe_multinode_previous_version`` was introduced. multinode-inputs.py and workflow files were updated accordingly.
Alex-Welsh
force-pushed
the
bump-multinode-workflow
branch
from
bf469d4 to
7addeae
Compare
Member
|
Simplified the logic a bit because it was getting less readable. I've essentially reverted 3ba886b. IDK why I thought that was a good idea in the first place |
Alex-Welsh
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make upgrading tests to work with new versioned terraform-kayobe-multinode branches.