Support and document persisting the Octavia CA #1988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This would be good to backport too :) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces valuable documentation and scripts for managing Octavia TLS certificates. The documentation is comprehensive but could be improved with some corrections to numbering and formatting for better clarity. The accompanying shell scripts are functional but contain some issues, such as using non-standard exit codes and suppressing error outputs, which could hinder debugging. I have provided specific suggestions to address these points and enhance the overall quality and robustness of the changes.
MoteHue
force-pushed
the
support-persisting-octavia-ca
branch
2 times, most recently
from
be8e59e to
8aa76ba
Compare
MoteHue
added
documentation
MoteHue
force-pushed
the
support-persisting-octavia-ca
branch
from
8aa76ba to
9958a80
Compare
Alex-Welsh
requested changes
Nov 18, 2025
MoteHue
force-pushed
the
support-persisting-octavia-ca
branch
from
d5406f8 to
43a0fd0
Compare
MoteHue
force-pushed
the
support-persisting-octavia-ca
branch
from
43a0fd0 to
8ad95f4
Compare
Member
|
/gemini review |
Alex-Welsh
force-pushed
the
support-persisting-octavia-ca
branch
from
8ad95f4 to
37da884
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.