Skip to content

fix: make internal secrets mutable #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
razvan wants to merge 1 commit into from
Closed

fix: make internal secrets mutable #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Fixed

- Do not make internal secrets immutable. Immutable secrets are cached and (accidental) deletes can render the cluster unusable ([#875]).

[#875]: https://github.com/stackabletech/trino-operator/pull/875

## [26.3.0] - 2026-03-16

## [26.3.0-rc1] - 2026-03-16
Expand Down
5 changes: 4 additions & 1 deletion rust/operator-binary/src/controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,7 +1536,10 @@ async fn create_random_secret(
internal_secret.insert(secret_key.to_string(), get_random_base64(secret_byte_size));

let secret = Secret {
immutable: Some(true),
// This secret used to be immutable but immutable secrets cannot be modified
// as they are heavily cached by Kubernetes.
// Different pods with different secrets will render the cluster unusable.
immutable: Some(false),
metadata: ObjectMetaBuilder::new()
.name(secret_name)
.namespace_opt(trino.namespace())
Expand Down
Loading