fix: make shared secrets stable across reconcile operations#874
Open
fix: make shared secrets stable across reconcile operations#874
Conversation
sbernauer
reviewed
Mar 30, 2026
Comment on lines
+1589
to
+1595
| openssl::pkcs5::pbkdf2_hmac( | ||
| seed, | ||
| b"", | ||
| 1, | ||
| openssl::hash::MessageDigest::sha256(), | ||
| &mut buf, | ||
| ) |
Member
There was a problem hiding this comment.
We already chatted in person, but I think this is problematic from a security perspective:
If a user knows the name of the stacklet, it can easily calculate the shared secret, in which case it is not secret any more ^^
Or another example: The TrinoClusters "trino" in dev, qa and prod namespaces share the same shared secret
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker