Quick and harmless fix to help with alternate OpenSearch schemas

[tloubrieu-jpl]

Related Issue(s):

• Partly helps with Allow injection of custom Elasticsearch/OpenSearch mappings via configuration #544
  (I did not want to create a new ticket which could be redundant with this one)

Description:

Have opensearch datetime, geometry and collections fields defined as constant string so to be easily overwritten when the OpenSearch mapping requires it, as shown in example https://github.com/NASA-PDS/registry-stac-api/blob/464ce37952367fa845b325e36263b04a1fd89965/src/pds/registry/stac/database_logic.py#L28

PR Checklist:

• Code is formatted and linted (run pre-commit run --all-files)
• Tests pass (run make test)
• Documentation has been updated to reflect changes, if applicable
• Changes are added to the changelog

[jonhealy1]

Hi @tloubrieu-jpl This looks really good. Can you add the same changes to the Elasticsearch backend. Thanks!

[tloubrieu-jpl]

Hello @jonhealy1 ,

I made the extension to elasticsearch,

I also realized that I initially missed some strings, derived from the constants newly defined, in the nested field syntax of elasticsearch/opensearch. I made this fix with the latest commit.

I re-ran the tests (make test) as well and I noticed some errors (5) that I initially missed but sounds unrelated to te change of this PR.

Thanks

[jonhealy1]

Tests pass here! @tloubrieu-jpl Thanks for making the updates.

How would you feel about adding environment variables? This would make it a lot easier for developers to modify these fields.

PROPERTIES_DATETIME_FIELD = os.getenv("STAC_FIELD_PROP_DATETIME", "properties.datetime")
PROPERTIES_START_DATETIME_FIELD = os.getenv("STAC_FIELD_PROP_START_DATETIME", "properties.start_datetime")
PROPERTIES_END_DATETIME_FIELD = os.getenv("STAC_FIELD_PROP_END_DATETIME", "properties.end_datetime")
COLLECTION_FIELD = os.getenv("STAC_FIELD_COLLECTION", "collection")
GEOMETRY_FIELD = os.getenv("STAC_FIELD_GEOMETRY", "geometry")