This repository was archived by the owner on Mar 18, 2021. It is now read-only.
Fixing the way aqueduct TestRequest serializes list query parameters #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now list query parameters were serialized in such a way: `url?query=[1, 2]`. This is not the way aqueduct expects list parameters to be sent with that pull request the way lists are serialized is: `url?query=1&query=2`
|
@Reductions I was trying to write a test like harness.publicAgent.get("/search", query: {"query": "1", "query": "2"});But soon realized that it's impossible do that in dart with the map containing duplicate keys. harness.publicAgent.get("/search", query: {"query": ["1", "2"]}); |
Contributor
Author
|
Yes it would. But it would not be merged as the framework is no longer supported. Run away while you have an option. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now list query parameters were serialized in such a way:
This is not the way aqueduct expects list parameters to be sent with that pull request the way lists are serialized is: