Open
Conversation
…ted with shipmonk/phpstan-baseline-per-identifier
staabm
reviewed
Apr 1, 2026
| } | ||
|
|
||
| // Skip loader.neon, which is used for loading baselines in phpstan-baseline-filter, but is not a baseline itself. | ||
| if (str_ends_with($baseline, 'loader.neon')) { |
Owner
There was a problem hiding this comment.
this file-name related to https://github.com/shipmonk-rnd/phpstan-baseline-per-identifier and the file-name can be freely chosen. so skipping based on the file-name alone seems like a bad idea.
meanwhile the usage docs suggest to use a _loader.neon file, which might resolve this problem?
Author
There was a problem hiding this comment.
Maybe a additional --exclude parameter could do the trick. That way it could even work for other implementations.
Owner
There was a problem hiding this comment.
yes. and --exclude should be also a glob-pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to handle baseline files that have been split into separate files