This repository was archived by the owner on Jun 10, 2018. It is now read-only.
Coerce null/undefined to empty string when escaping#16
Open
emma-borhanian wants to merge 1 commit intosstephenson:masterfrom
emma-borhanian:coerce-nulls
Open
Coerce null/undefined to empty string when escaping#16emma-borhanian wants to merge 1 commit intosstephenson:masterfrom emma-borhanian:coerce-nulls
emma-borhanian wants to merge 1 commit intosstephenson:masterfrom
emma-borhanian:coerce-nulls
Conversation
|
👍 this effects my project as well, and would be a very convenient change |
|
Why not extract the escaping function and put it with the |
Author
|
I was planning on making a follow-up pull request to perform that optimization, and also apply it to the "escape_function" at the same time. Unfortunately it looks like this project is dead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you use escape tags with a null value it will be turned into the string "null", which can be incredibly inconvenient.
For example
becomes
This patch changes the result to:
This is consistent with the behavior of e.g. erb