This repository was archived by the owner on Jun 10, 2018. It is now read-only.
Fix for turnaries always being truthy when passed to escaping EJS tags.#13
Open
onyxrev wants to merge 1 commit intosstephenson:masterfrom
Open
Fix for turnaries always being truthy when passed to escaping EJS tags.#13onyxrev wants to merge 1 commit intosstephenson:masterfrom
onyxrev wants to merge 1 commit intosstephenson:masterfrom
Conversation
The implementation was prepending an empty string blindly to the front of the fragment provided to the tags which caused the turnary to always be evaluated truthily.
Author
|
"||" operators are also broken in the current implementation and fixed with this pull request: <%- this.value || "no value" %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation was prepending an empty string blindly to the front of the fragment provided to the tags which caused the turnary to always be evaluated truthily.
Example:
...was producing:
... which is always truthy because of the type coercion. It now produces:
... which properly honors the intention of the evaluation.