[recode] Account for spilled values of four bytes#21
Open
blackgeorge-boom wants to merge 1 commit intossrg-vt:mainfrom
Open
[recode] Account for spilled values of four bytes#21blackgeorge-boom wants to merge 1 commit intossrg-vt:mainfrom
blackgeorge-boom wants to merge 1 commit intossrg-vt:mainfrom
Conversation
Currently, the `recode` functionality assumes that a `live_value` that is not an alloca should have a default size of 8 bytes. However, we have encountered cases, like in the Unifico-compiled `loop` example, where a spilled value can be of size 4. Thus, we extend the rewrite functions `_get_val` and `_put_val`, to account for this case as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
recodefunctionality assumes that alive_valuethat is not an alloca should have a default size of 8 bytes. However, a spilled value can be of size 4 as well. Thus, we extend the rewrite functions_get_valand_put_val, to account for this case.