Skip to content

Fix the validation errors#7

Merged
ssilverman merged 2 commits into
ssilverman:masterfrom
peternewman:patch-5
Aug 2, 2021
Merged

Fix the validation errors#7
ssilverman merged 2 commits into
ssilverman:masterfrom
peternewman:patch-5

Conversation

@peternewman

@peternewman peternewman commented Jun 27, 2021

Copy link
Copy Markdown
Contributor

So the JSON is actually valid!

See also my incoming public review docs

@ssilverman ssilverman left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for finding these.

@ssilverman ssilverman left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, @peternewman could you combine the commits into a single commit and then force push?

@peternewman

Copy link
Copy Markdown
Contributor Author

@peternewman

Copy link
Copy Markdown
Contributor Author

Is the Squash and Merge option acceptable @ssilverman or do you want me to have a go from my end?

@ssilverman

ssilverman commented Jul 28, 2021

Copy link
Copy Markdown
Owner

I'm familiar with squash merges, I just wanted to give you an opportunity to create your own commit message. If you don't want to, I'll just create a commit and give you credit in the comments.

@ssilverman

Copy link
Copy Markdown
Owner

See: #6 (comment)

@ssilverman ssilverman merged commit d3a0089 into ssilverman:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants