[RORDEV-1520] Loading ROR settings logic refactoring #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coutoPL
added a commit
that referenced
this pull request
Dec 21, 2025
new ES 9.2.2, 9.1.8, 8.19.8 support (#1190) wip wip wip wip wip [RORDEV-1574] New `logged_user` audit field (#1170) using openjdk:22-jdk-slim in azure pipeline (#1177) [RORDEV-1573] Enable/Disable audit per block (#1175) [RORDEV-1567] ECS serializer and improved configurable serializer (#1165) [RORDEV-1567] Use new logged_user field in the ECS serializer (#1179) [RORDEV-1857] pipeline: ES_S3_UP stage fix (#1183) pipeline fix [RORDEV-1857] Fix for Windows-based CI jobs (#1185) [RORDEV-1862] Round-robin mode for ROR audit remote cluster (#1186) [RORDEV-1879] Do not include full request body in ECS serializer by default (#1189) [RORDEV-1900] added: LDAP connection health check and max age settings (#1195) [RORDEV-1520] Loading ROR settings logic refactoring (#1191) [RORDEV-1902][RORDEV-1904][RORDEV-1906] ES 9.2.3, 9.1.9, 8.19.9 support (#1196) wip reftactor porting changes to other modules porting changes to other modules
coutoPL
added a commit
that referenced
this pull request
Dec 21, 2025
new ES 9.2.2, 9.1.8, 8.19.8 support (#1190) wip wip wip wip wip [RORDEV-1574] New `logged_user` audit field (#1170) using openjdk:22-jdk-slim in azure pipeline (#1177) [RORDEV-1573] Enable/Disable audit per block (#1175) [RORDEV-1567] ECS serializer and improved configurable serializer (#1165) [RORDEV-1567] Use new logged_user field in the ECS serializer (#1179) [RORDEV-1857] pipeline: ES_S3_UP stage fix (#1183) pipeline fix [RORDEV-1857] Fix for Windows-based CI jobs (#1185) [RORDEV-1862] Round-robin mode for ROR audit remote cluster (#1186) [RORDEV-1879] Do not include full request body in ECS serializer by default (#1189) [RORDEV-1900] added: LDAP connection health check and max age settings (#1195) [RORDEV-1520] Loading ROR settings logic refactoring (#1191) [RORDEV-1902][RORDEV-1904][RORDEV-1906] ES 9.2.3, 9.1.9, 8.19.9 support (#1196) wip reftactor porting changes to other modules porting changes to other modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
ROR configis nowROR settings(we still use the word "config" in the context of ES config)EsConfigBasedRorSettingswas introduced. It holds all elasticsearch.yml-related ROR settings and/or ROR properties settings. Anything that ROR needs to know before starting. These settings cannot be reloaded.MainRorSettingsandTestRorSettingsare reloadable.a) ROR defines now the
SettingsSourceinterface. Its implementations define the way ROR reads and saves settingsb) ROR defines now the
StartingRorSettingsLoaderinterface. It defines how to load the Main & Test ROR settingsc) The loading retry strategy was decoupled from the loading logic
d) ROR settings auto-reloader from the
RorInstancelogic code