feat(auth): Add web authentication with django-allauth#993
feat(auth): Add web authentication with django-allauth#993
Conversation
|
@daiv-agent /code-review |
Findings1. Details
Consider removing 2. DetailsWith django-allauth's own documentation explicitly warns about this setting and recommends keeping it 3. Details
Consider adding an explicit pre-check or making the command exit 0 with a warning instead of raising Suggestions
Tests
|
Add social login (GitHub, GitLab), passwordless login-by-code, styled login/dashboard pages, and API key management UI. - django-allauth with conditional provider registration - Tailwind CSS v4 via standalone CLI (ARM-compatible) - WhiteNoise for static file serving - Dark-themed login, code entry, dashboard, and API keys pages - setup_default_site management command (reads DAIV_EXTERNAL_URL) - Custom social account adapter for GitLab server URL separation
60a8b38 to
79dc9b5
Compare
Change <script> to <script type="module"> so the toast auto-dismiss logic does not block page rendering.
The version was hardcoded in both Dockerfiles. A top-level ARG with a default makes upgrades a single-edit operation per file and allows overriding at build time via --build-arg.
Set a stable urls_namespace="api" on NinjaAPI so the dashboard template
can use {% url 'api:openapi-view' %} instead of a hardcoded path.
Cover the happy-path create flow, ownership check (a user cannot revoke another user's key), already-revoked guard, and login-required redirects.
Replace single accounts/urls.py with allauth_urls.py, api_keys_urls.py, and dashboard_urls.py. Move custom GitLab OAuth and allauth routes from the root urlconf into accounts/allauth_urls.py so each concern has its own module.
Add social login (GitHub, GitLab), passwordless login-by-code, styled login/dashboard pages, and API key management UI.